ci(ingest/kafka): improve kafka integration test reliability #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
May 25, 2023
Comment on lines
+86
to
+90
| filterwarnings = | ||
| # Ignore some warnings that come from dependencies. | ||
| ignore:Deprecated call to \`pkg_resources.declare_namespace:DeprecationWarning | ||
| ignore:pkg_resources is deprecated as an API:DeprecationWarning | ||
| ignore:Did not recognize type:sqlalchemy.exc.SAWarning |
There was a problem hiding this comment.
It's annoying seeing these calls but aren't these things we should potentially be worried about, esp if we update any dependencies?
There was a problem hiding this comment.
we talked about this offline
Comment on lines
+6
to
+8
| @pytest.mark.filterwarnings( | ||
| "ignore:pkg_resources is deprecated as an API:DeprecationWarning" | ||
| ) |
There was a problem hiding this comment.
Is this redundant with above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some warnings cleanup.
Checklist