fix(ingestion/looker): set project-name for imported_projects views #8086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
siddiquebagwan
changed the title
hsheth2
reviewed
May 25, 2023
| view_project_map: Dict[str, str] = {} | ||
| for view_field in view_fields: | ||
| if view_field.view_name is not None and view_field.project_name is not None: | ||
| view_project_map[view_field.view_name] = view_field.project_name |
There was a problem hiding this comment.
does this break if you have the same view name in two projects?
There was a problem hiding this comment.
view within a model has a unique name, so it wouldn't break as it is getting used by LookerExplore.from_api.
I added the respective doc string in the function.
…:mohdsiddique/datahub into master+ing-74-looker-refinements-lineage
…:acryldata/datahub-fork into master+ing-74-looker-refinements-lineage
…:acryldata/datahub-fork into master+ing-74-looker-refinements-lineage
hsheth2
approved these changes
Jun 1, 2023
| @@ -734,7 +691,9 @@ def from_api( # noqa: C901 | |||
| fields=view_fields, | |||
| upstream_views=list( | |||
| ProjectInclude( | |||
| project=_BASE_PROJECT_NAME, | |||
| project=_BASE_PROJECT_NAME | |||
| if view_name not in view_project_map | |||
There was a problem hiding this comment.
can change this to view_project_map.get(view_name, _BASE_PROJECT_NAME)
Yup, It is just refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.