fix(ingest/csv-enricher): Adding extra check in csv enricher to ignore non-urn urns #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Jun 7, 2023
Comment on lines
+549
to
+551
| GlossaryTermAssociationClass(term) | ||
| for term in term_urns | ||
| if term.startswith("urn:li:") |
There was a problem hiding this comment.
Is this just due to an ill-formatted file? Can we instead append url:li if it doesn't start with that, like we do elsewhere in make_data_platform_urn for example
There was a problem hiding this comment.
No that is not possible. People are using this for terms while their actual URNs are UUIDs.
There was a problem hiding this comment.
Feel free to stamp this one then. I don't understand what's going on here
anshbansal
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist