Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(classification): support for regex based custom infotypes #8177

Merged
merged 4 commits into from
Jun 6, 2023
Merged

feat(classification): support for regex based custom infotypes #8177

merged 4 commits into from
Jun 6, 2023

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 6, 2023
treff7es
treff7es reviewed Jun 6, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/glossary/datahub_classifier.py Outdated
values["info_types_config"][k] = v
@root_validator(pre=False)
def input_config_selectively_overrides_default_config(cls, values):
input_config: Dict[str, InfoTypeConfig] = values.get("info_types_config")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be None if info_types_config doesn't exist, right?

Copy link
Collaborator Author

@mayurinehate mayurinehate Jun 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the data type of info_types_config is not Optional. also the default value is set, so I don't think this will ever be None. We already have tests that confirm this works fine without specifying info_types_config in config. Let me know if I am missing anything. I also moved this from root_validator to field validator here.

treff7es
treff7es approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 983a8ca into datahub-project:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @treff7es