-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(classification): support for regex based custom infotypes #8177
Conversation
values["info_types_config"][k] = v | ||
@root_validator(pre=False) | ||
def input_config_selectively_overrides_default_config(cls, values): | ||
input_config: Dict[str, InfoTypeConfig] = values.get("info_types_config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be None if info_types_config
doesn't exist, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the data type of info_types_config is not Optional. also the default value is set, so I don't think this will ever be None. We already have tests that confirm this works fine without specifying info_types_config in config. Let me know if I am missing anything. I also moved this from root_validator
to field validator
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Checklist