Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vulnerabilities)/vulnerabilities_fixes_datahub (#8075) #8189

Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix(vulnerabilities)/vulnerabilities_fixes_datahub (#8075) #8189

merged 3 commits into from
Jun 7, 2023

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker david-leifker mentioned this pull request Jun 7, 2023
Merged
5 tasks
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jun 7, 2023
@david-leifker david-leifker self-assigned this Jun 7, 2023
@david-leifker
add auth verbose logging flag
baf4d5f 
construct the authentication exception with cause
RyanHolstien
RyanHolstien approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadocs say initCause is the newer way to add the rootCause rather than setRootCause, but lgtm

@david-leifker david-leifker merged commit 81fdf9d into master Jun 7, 2023
34 checks passed
@david-leifker david-leifker deleted the nt-nuodata-vulnerabilites_fixes_datahub branch June 7, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees

@david-leifker david-leifker

Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-leifker @RyanHolstien @Sejal-NucleusTeq