fix(vulnerabilities)/vulnerabilities_fixes_datahub #8075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
Sejal-NucleusTeq
changed the title
Sejal-NucleusTeq
changed the title
Sejal-NucleusTeq
changed the title
build.gradle
Outdated
| @@ -89,7 +89,7 @@ project.ext.externalDependency = [ | |||
| 'elasticSearchRest': 'org.elasticsearch.client:elasticsearch-rest-high-level-client:' + elasticsearchVersion, | |||
| 'elasticSearchTransport': 'org.elasticsearch.client:transport:' + elasticsearchVersion, | |||
| 'findbugsAnnotations': 'com.google.code.findbugs:annotations:3.0.1', | |||
| 'graphqlJava': 'com.graphql-java:graphql-java:' + graphQLJavaVersion, | |||
| 'graphqlJava': 'com.graphql-java:graphql-java:19.4', | |||
There was a problem hiding this comment.
The version here should be incremented above from ext.graphQLJavaVersion = '19.0' to the 19.4 version.
build.gradle
Outdated
| 'zookeeper': 'org.apache.zookeeper:zookeeper:3.4.14', | ||
| 'wire': 'com.squareup.wire:wire-compiler:3.7.1', | ||
| 'charle': 'com.charleskorn.kaml:kaml:0.53.0', | ||
| 'jsonv': 'org.json:json:20230227', |
There was a problem hiding this comment.
Looks like this is duplicated above 'json': 'org.json:json:20230227', is the same as this one. Please consolidate to one.
datahub-upgrade/build.gradle
Outdated
| @@ -23,6 +25,9 @@ dependencies { | |||
| exclude group: "org.apache.htrace", module: "htrace-core4" | |||
| exclude group: "org.eclipse.jetty", module: "jetty-util" | |||
| exclude group: "org.apache.hadoop.thirdparty", module: "hadoop-shaded-protobuf_3_7" | |||
| exclude group: "com.charleskorn.kaml",module:"kaml" | |||
There was a problem hiding this comment.
Couple of linting issues here, please add a space after the , to match the others. Thanks!
|
|
||
| configurations.all{ | ||
| exclude group: "commons-io",module:"commons-io" |
There was a problem hiding this comment.
Similar to above linting command, please add a space after the comma.
| } | ||
|
|
||
| configurations.all{ | ||
| exclude group: "com.charleskorn.kaml",module:"kaml" |
metadata-service/war/build.gradle
Outdated
| implementation externalDependency.charle | ||
| } | ||
| configurations.all{ | ||
| exclude group: "com.charleskorn.kaml",module:"kaml" |
|
Overall this looks good, just a few minor updates. If you enable us to modify the branch I can fix up the minor issues, otherwise look forward to a slight revision. Thank you for this! |
|
Hey David-leifker
Changes are made according to the reviews.
Thankyou
Sejal Jain
Nucleus Teq
…On Fri, May 19, 2023 at 3:12 AM david-leifker ***@***.***> wrote:
Overall this looks good, just a few minor updates. If you enable us to
modify the branch I can fix up the minor issues, otherwise look forward to
a slight revision. Thank you for this!
—
Reply to this email directly, view it on GitHub
<#8075 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2DQ3SYOJVKC4SRKFDRKM7DXG2JUFANCNFSM6AAAAAAYGC6EU4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
david-leifker
approved these changes
May 19, 2023
|
Some of these fixes may have already been introduced to master, I suspect this is the branch conflicts. If possible please review the conflicts so that if there are remaining changes, we can merge them. Thank you! |
shirshanka
added
release-0.10.3
community-contribution
|
okey sure
…On Tue, May 23, 2023 at 1:14 AM david-leifker ***@***.***> wrote:
Some of these fixes may have already been introduced to master, I suspect
this is the branch conflicts. If possible please review the conflicts so
that if there are remaining changes, we can merge them. Thank you!
—
Reply to this email directly, view it on GitHub
<#8075 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2DQ3S7YD5U4KEMGRSTLIHTXHO6ZBANCNFSM6AAAAAAYGC6EU4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hello David-leifker |
david-leifker
approved these changes
Jun 7, 2023
david-leifker
changed the base branch from
master
to
nt-nuodata-vulnerabilites_fixes_datahub
david-leifker
merged commit 6ca2653
into
datahub-project:nt-nuodata-vulnerabilites_fixes_datahub
|
Merged to alternative branch so I can make sure all the tests are passing for before merging. Plan is to merge from that branch. #8189 |
david-leifker
added a commit
that referenced
this pull request
Jun 7, 2023
|
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist