Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/quickstart): handle docker hangs gracefully #8211

Merged
merged 5 commits into from
Jun 13, 2023
Merged

fix(cli/quickstart): handle docker hangs gracefully #8211

merged 5 commits into from
Jun 13, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jun 10, 2023 •
edited
Loading

  • Handle retries when docker compose up hangs.
  • Tweaks our healthchecks so that the startup grace periods are longer.

The changes in docker/quickstart are autogenerated from the ones in the docker/ dir.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(cli/quickstart): handle docker hangs gracefully
73489b8 
Also tweaks our healthchecks so that the startup grace periods are
longer.
@hsheth2 hsheth2 requested a review from shirshanka June 10, 2023 00:20
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata labels Jun 10, 2023
@david-leifker david-leifker merged commit e5f9ee1 into datahub-project:master Jun 13, 2023
@hsheth2 hsheth2 deleted the docker-startup-order branch June 13, 2023 19:48
david-leifker pushed a commit that referenced this pull request Jun 13, 2023
@hsheth2 @pedro93 @david-leifker
fix(cli/quickstart): handle docker hangs gracefully (#8211)
e00d685 
Co-authored-by: Pedro Silva <pedro@acryl.io>
tusharm pushed a commit to tusharm/datahub that referenced this pull request Jun 20, 2023
@hsheth2 @pedro93 @tusharm
fix(cli/quickstart): handle docker hangs gracefully (datahub-project#…
fcd5029 
…8211)

Co-authored-by: Pedro Silva <pedro@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @david-leifker @pedro93