feat(ingest/bigquery_v2): enable platform instance using project id #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atahub-project#8142) Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Jun 12, 2023
| @@ -140,7 +142,8 @@ def cleanup(config: BigQueryV2Config) -> None: | |||
| @support_status(SupportStatus.CERTIFIED) | |||
| @capability( | |||
| SourceCapability.PLATFORM_INSTANCE, | |||
| "Not supported since BigQuery project ids are globally unique", | |||
| "Platform instance is pre-set to the BigQuery project id, " | |||
| "but not added to urns as project ids are included in the container path.", | |||
There was a problem hiding this comment.
the "not added to urns" part can be a # comment, but doesn't need to show up in our docs
There was a problem hiding this comment.
Yeah guess that's an implementation detail
|
Deployment failed with the following error: |
|
@asikowitz re-queuing CI since it looks like it failed due to the Github incident yesterday |
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
…atahub-project#8216) Co-authored-by: Adrián Pertíñez <khurzak92@gmail.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 743439c
Checklist