fix(patch): Fix exception when using default patch for patching missing aspects #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
changed the title
metadata-io/src/main/java/com/linkedin/metadata/entity/EntityService.java
Show resolved
Hide resolved
RyanHolstien
approved these changes
Jun 12, 2023
tusharm
pushed a commit
to tusharm/datahub
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, I fix a bug where if you try to patch an aspect that does not exist, the write will fail.
This is because when we set latest to another value, then inside the "ingest" method we try to perform an "update" on a row instead of an "insert".
The update then fails because we try to update a row that does not exist. This change switches so that we set latest to "null" when the aspect does not exist yet, which forces an insert instead of an update and thus fixes the exception
Status
Ready for review
Checklist