Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gms): GMS hang when upgrade image #8270 #8271

Merged
merged 5 commits into from
Jul 29, 2023
Merged

fix(gms): GMS hang when upgrade image #8270 #8271

merged 5 commits into from
Jul 29, 2023

Conversation

yangjiandan
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yangjiandan
Copy link
Contributor Author

@david-leifker Could you help me review this pr?

@yangjiandan
Copy link
Contributor Author

issue description about this pr is #8270

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jun 21, 2023
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jun 23, 2023
@yangjiandan
Copy link
Contributor Author

@shirshanka Could you help me review this pr?

@david-leifker
Copy link
Collaborator

The topic is not intended to expire messages, I don't see any issues with including this, just slightly tweaking the conditional to set the static atomic in case we ever need to refer to that state later. Thanks!

@david-leifker david-leifker merged commit 753b0f1 into datahub-project:master Jul 29, 2023
31 checks passed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@yangjiandan @david-leifker @yoonhyejin
fix(gms): GMS hang when upgrade image #8270 (#8271)
dcd2905 
Co-authored-by: yangjd33 <yangjd33@chinaunicom.cn>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangjiandan @david-leifker @anshbansal