feat(ingest/kafka-connect): add support for Confluent S3 Sink Connector #8298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
requested changes
Jun 26, 2023
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka_connect.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/tests/integration/kafka-connect/test_kafka_connect_s3sink.py
Outdated
Show resolved
Hide resolved
anshbansal
added
the
community-contribution
tusharm
force-pushed
the
add-s3-sink-connector
branch
from
0fe2751
to
c5a9644
Compare
metadata-ingestion/tests/integration/kafka-connect/kafka_connect_s3sink_to_file.yml
Show resolved
Hide resolved
mayurinehate
approved these changes
Jul 13, 2023
|
@mayurinehate anything else needed to merge this? |
Hey @tusharm, Thank you for patience. Once CI passes, it should be good to merge from my side. |
maggiehays
added
the
merge-pending-ci
asikowitz
approved these changes
Jul 17, 2023
|
hey @anshbansal, I see one of the checks failing - doesn’t seem related to changes in this PR. Is this error specific on this branch? |
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://feature-requests.datahubproject.io/p/confluent-s3-sink-connector-as-a-source
Note:
I tried updating the existing test
test_kafka_connect.pybut the fixture that creates the docker-compose setup, kept failing due to timeouts. To work around that, I created an entirely separate test.I understand there is a bit of duplication but if the former approach works in the CI, happy to port my test back into
test_kafka_connect.py.Checklist