Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): ignore case when comparing http headers #8356

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix(auth): ignore case when comparing http headers #8356

merged 3 commits into from
Jul 31, 2023

Conversation

lix-mms
Copy link
Contributor

@lix-mms lix-mms commented Jul 3, 2023

  • ensure authorization header is correctly removed, so no duplication of token when header is added down a few lines
  • adjusted similar cases for other headers

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@lix-mms
fix(auth): ignore case when comparing http headers
35aa5d6 
* ensure authorization header is correctly removed, so no duplication of token when added again
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jul 3, 2023
@lix-mms
Copy link
Contributor Author

lix-mms commented Jul 3, 2023 •
edited
Loading

Http.HeaderNames.AUTHORIZATION has value "Authorization", while entry.getKey() has lower-case values like "authorization". Thus this fix.

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jul 17, 2023
chriscollins3456
chriscollins3456 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable to me! thanks for this

@anshbansal anshbansal merged commit 352a54a into datahub-project:master Jul 31, 2023
32 checks passed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@lix-mms @yoonhyejin
fix(auth): ignore case when comparing http headers (#8356)
0026d57
@lix-mms lix-mms deleted the patch-1 branch August 24, 2023 09:15
spadhi7 added a commit to spadhi7/datahub that referenced this pull request Aug 29, 2023
@spadhi7
Merge tag 'v0.10.5' into filesink_json
4fe52d7 
* tag 'v0.10.5': (222 commits)
  fix(test): increase siblings.js test stability (datahub-project#8542)
  feat(search): Allow aggregating on facets that are not explicitly part of default filter set (datahub-project#8540)
  fix(ui) Make multiple small updates to new search and browse (datahub-project#8524)
  feat(presto-on-hive): allow v1 fieldpaths in the presto-on-hive source (datahub-project#8474)
  feat(cli): Adds ability to upload recipes to DataHub's UI (datahub-project#8317)
  feat(browseV2): add browseV2 logic to system update (datahub-project#8506)
  fix(ingest/json-schema): convert non-string enums to strings (datahub-project#8479)
  feat(ingestion/tableau): support column level lineage for custom sql (datahub-project#8466)
  test(ingest): test case statements with sql parser (datahub-project#8437)
  feat(ingest/vertica): performance improvement and bug fixes (datahub-project#8328)
  ci: reduce git fetch depth (datahub-project#8473)
  fix(ingest): remove duplication of tags (datahub-project#8532)
  docs: small update to homepage (datahub-project#8483)
  fix(ingest): pin boto3-stubs in CI (datahub-project#8527)
  feat(siblings): hiding non-existant siblings in FE (datahub-project#8528)
  fix(ingest/build): Fix sagemaker mypy and flake8 issues (datahub-project#8530)
  feat(metrics): add metrics for aspect write and bytes (datahub-project#8526)
  feat(elasticsearch): allow bulk delete (datahub-project#8424)
  fix(ui): use locale lowercase when filtering columns of an entity in the lineage (datahub-project#8213)
  fix(auth): ignore case when comparing http headers (datahub-project#8356)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lix-mms @chriscollins3456 @anshbansal