feat(elasticsearch): allow bulk delete #8424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch writes to elasticsearch generally contain only create/upsert requires while deletes are typically isolated. This PR offers the ability to allow combining delete requests (including delete_by_query) with upserts. If used responsibly this works fine, however in the past delete/modify requests effecting the same document was observed in the same batch of requests. This conflict caused inconsistencies due to failed bulk requests. In general, probably useful only in extreme cases, and temporarily, for bulk delete operations.
Checklist