Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/bigquery): add tag to BigQuery clustering columns #8495

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

ANich
Copy link
Contributor

@ANich ANich commented Jul 24, 2023

Adds as CLUSTERING_COLUMN_{x} tag to each clustering column in a BigQuery table. x is a 1-index int (in BigQuery queries must filter by these in order to take advantage of performance gains - see docs).

Uses CLUSTERING_ORDINAL_POSITION from the INFORMATION_SCHEMA.COLUMNS View - see docs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
    - [] Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
    - [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
    - [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 24, 2023
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We're moving away from using the tag to represent the partition key, but I don't see a solution for labeling cluster columns so this makes sense to me

@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 17, 2023
@asikowitz
Copy link
Collaborator

Merging as the test failures don't look relevant

@asikowitz asikowitz merged commit c0addf6 into datahub-project:master Aug 17, 2023
42 of 44 checks passed
@ANich ANich deleted the bigquery_clustering branch August 17, 2023 17:10
asikowitz added a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
…b-project#8495)

Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants