Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openapi): entity endpoints & analytics raw #8537

Merged
merged 17 commits into from
Sep 7, 2023
Merged

feat(openapi): entity endpoints & analytics raw #8537

merged 17 commits into from
Sep 7, 2023

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Aug 1, 2023 •
edited

  • Expand OpenAPI with core entities and a few aspects
  • Raw experimental OpenAPI endpoint to DataHub Usage Events

Screenshot 2023-08-08 at 7 04 54 AM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker
Copy link
Collaborator Author

Ran locally needs tests, looking for early feedback.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Aug 1, 2023
RyanHolstien
RyanHolstien reviewed Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth having a Zoom review/demo over this one if you have bandwidth, there's a lot going on esp in the OpenApiEntities class. I think all the changes to the existing logic make sense to me though.

buildSrc/src/main/java/io/datahubproject/OpenApiEntities.java Outdated Show resolved Hide resolved
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/util/MappingUtil.java Show resolved Hide resolved
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/util/MappingUtil.java Outdated Show resolved Hide resolved
...-entity-servlet/src/main/java/io/datahubproject/openapi/delegates/EntityApiDelegateImpl.java Show resolved Hide resolved
@david-leifker david-leifker mentioned this pull request Aug 2, 2023
Closed
5 tasks
@david-leifker david-leifker removed ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Aug 2, 2023
@david-leifker
Merge remote-tracking branch 'datahub-project/master' into openapi-im…
37aa80d 
…provements

# Conflicts:
#	metadata-io/build.gradle
#	metadata-models/build.gradle
@david-leifker
Copy link
Collaborator Author

Add test for custom entity.

shirshanka
shirshanka approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-leifker david-leifker merged commit 56c00f5 into datahub-project:master Sep 7, 2023
61 of 63 checks passed
spadhi7 added a commit to spadhi7/datahub that referenced this pull request Oct 4, 2023
@spadhi7
Merge tag 'v0.11.0' into filesink_json
eb7699c 
* tag 'v0.11.0': (188 commits)
  fix(spark-test): upgrade gradle and fix spark smoke test (datahub-project#8777)
  fix(gms): Fixed Recently Viewed section for users with '@' in the URN. (datahub-project#8754)
  feat: add feedback widget (datahub-project#8732)
  fix(custom-search): fix custom search to be able to use unquoted query (datahub-project#8805)
  docs(db-retention): update with default setting (datahub-project#8797)
  feat(openapi): entity endpoints & analytics raw (datahub-project#8537)
  feat(search): Also de-duplicate the field queries based on field names (datahub-project#8788)
  fix(ingest): drop `wrap_aspect_as_workunit` method (datahub-project#8766)
  feat(ingest): drop sql_metadata parser (datahub-project#8765)
  docs: minor fix on versioning navbar and dropdown (datahub-project#8790)
  chore(ingest): upgrade sqlglot fork (datahub-project#8775)
  docs: add datahub source to integrations page (datahub-project#8787)
  fix(ingest/bigquery): fix partition and median queries for profiling (datahub-project#8778)
  fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations (datahub-project#8779)
  refactor(ingest): Add support for group-owners in dataflow entities (datahub-project#8154)
  feat(systemMetadata): Adding a lastRunId field system metadata  (datahub-project#8672)
  feat(airflow-plugin): add package type information (datahub-project#8795)
  fix(ingest/datahub): Support postgres; build(postgres): Modernize postgres docker setup (datahub-project#8762)
  docs(session): add documentation for session token duration and fix default (datahub-project#8791)
  chore(analytics): bump version (datahub-project#8786)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@iprentic iprentic Awaiting requested review from iprentic

@anshbansal anshbansal Awaiting requested review from anshbansal

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

Assignees

@shirshanka shirshanka

Labels
devops PR or Issue related to DataHub backend & deployment release-0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-leifker @shirshanka @RyanHolstien