fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations #8779

mayurinehate · 2023-09-04T09:43:38Z

Snowflake schema field urns should be lowercased . Issue reported on slack thread
Fix empty workbook response in chart graphql api. Issue reported on slack thread
Add type annotations across snowflake and tableau sources to improve mypy coverage.

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

…ative_cll_fix' into tableau_snowflake_native_cll_fix

mayurinehate · 2023-09-04T10:04:28Z

metadata-ingestion/src/datahub/ingestion/source/tableau.py

@@ -1086,9 +1093,12 @@ def get_upstream_columns_of_fields_in_datasource(
                    and upstream_table_id
                    and upstream_table_id in table_id_to_urn.keys()
                ):
+                    parent_dataset_urn = table_id_to_urn[upstream_table_id]
+                    if self.is_snowflake_urn(parent_dataset_urn):
+                        name = name.lower()


fix for tableau native CLL with snowflake upstream

could you add a comment explaining that the snowflake source lowercases column names, so this behavior is to match that?

mayurinehate · 2023-09-04T10:05:20Z

metadata-ingestion/src/datahub/ingestion/source/tableau.py

-                    f"/{workbook[tableau_constant.NAME].replace('/', REPLACE_SLASH_CHAR)}"
-                ]
-            )
+        browse_paths = self.get_browse_paths_aspect(workbook)


fix for handling null workbook dict returned in chart graphql api response

mayurinehate · 2023-09-04T10:05:52Z

metadata-ingestion/src/datahub/ingestion/source/tableau.py

@@ -2378,32 +2386,8 @@ def emit_dashboard(
            if wu is not None:
                yield wu

-        project_luid: Optional[str] = self._get_workbook_project_luid(workbook)


Fix for handling empty workbook dict returned in dashboard graphql api response

metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_config.py

hsheth2 · 2023-09-05T18:09:34Z

metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_lineage_v2.py

+        dataset_urn: str,
+        fine_upstreams: List[FineGrainedLineage],
+        column_with_upstreams: Dict,
+    ) -> None:


thanks for adding these annotations

hsheth2 · 2023-09-05T18:14:02Z

metadata-ingestion/src/datahub/ingestion/source/tableau.py

@@ -1086,9 +1093,12 @@ def get_upstream_columns_of_fields_in_datasource(
                    and upstream_table_id
                    and upstream_table_id in table_id_to_urn.keys()
                ):
+                    parent_dataset_urn = table_id_to_urn[upstream_table_id]
+                    if self.is_snowflake_urn(parent_dataset_urn):
+                        name = name.lower()


could you add a comment explaining that the snowflake source lowercases column names, so this behavior is to match that?

…flake_config.py Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* tag 'v0.11.0': (188 commits) fix(spark-test): upgrade gradle and fix spark smoke test (datahub-project#8777) fix(gms): Fixed Recently Viewed section for users with '@' in the URN. (datahub-project#8754) feat: add feedback widget (datahub-project#8732) fix(custom-search): fix custom search to be able to use unquoted query (datahub-project#8805) docs(db-retention): update with default setting (datahub-project#8797) feat(openapi): entity endpoints & analytics raw (datahub-project#8537) feat(search): Also de-duplicate the field queries based on field names (datahub-project#8788) fix(ingest): drop `wrap_aspect_as_workunit` method (datahub-project#8766) feat(ingest): drop sql_metadata parser (datahub-project#8765) docs: minor fix on versioning navbar and dropdown (datahub-project#8790) chore(ingest): upgrade sqlglot fork (datahub-project#8775) docs: add datahub source to integrations page (datahub-project#8787) fix(ingest/bigquery): fix partition and median queries for profiling (datahub-project#8778) fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations (datahub-project#8779) refactor(ingest): Add support for group-owners in dataflow entities (datahub-project#8154) feat(systemMetadata): Adding a lastRunId field system metadata (datahub-project#8672) feat(airflow-plugin): add package type information (datahub-project#8795) fix(ingest/datahub): Support postgres; build(postgres): Modernize postgres docker setup (datahub-project#8762) docs(session): add documentation for session token duration and fix default (datahub-project#8791) chore(analytics): bump version (datahub-project#8786) ...

fix(ingest/tableau): fix tableau native CLL for snowflake

1d26c77

github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 4, 2023

vercel bot deployed to Preview September 4, 2023 09:58 View deployment

mayurinehate and others added 3 commits September 4, 2023 15:29

Merge branch 'master' into tableau_snowflake_native_cll_fix

be5ffdc

fix lint

4823948

Merge remote-tracking branch 'refs/remotes/origin/tableau_snowflake_n…

1995ac8

…ative_cll_fix' into tableau_snowflake_native_cll_fix

mayurinehate changed the title ~~fix(ingest/tableau): fix tableau native CLL for snowflake, better type handling~~ fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations Sep 4, 2023

mayurinehate commented Sep 4, 2023

View reviewed changes

vercel bot deployed to Preview September 4, 2023 10:26 View deployment

mayurinehate requested review from hsheth2 and asikowitz September 5, 2023 12:06

Merge branch 'master' into tableau_snowflake_native_cll_fix

c5c04eb

vercel bot deployed to Preview September 5, 2023 13:17 View deployment

hsheth2 reviewed Sep 5, 2023

View reviewed changes

mayurinehate and others added 2 commits September 6, 2023 10:23

Update metadata-ingestion/src/datahub/ingestion/source/snowflake/snow…

f03f332

…flake_config.py Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

Update tableau.py add comment

cafa765

vercel bot deployed to Preview September 6, 2023 05:22 View deployment

hsheth2 approved these changes Sep 6, 2023

View reviewed changes

hsheth2 merged commit 8bf28bf into datahub-project:master Sep 6, 2023
58 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations #8779

fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations #8779

mayurinehate commented Sep 4, 2023

mayurinehate Sep 4, 2023

hsheth2 Sep 5, 2023

mayurinehate Sep 6, 2023

mayurinehate Sep 4, 2023 •

edited

mayurinehate Sep 4, 2023

hsheth2 Sep 5, 2023

hsheth2 Sep 5, 2023

fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations #8779

fix(ingest/tableau): fix tableau native CLL for snowflake, add type annotations #8779

Conversation

mayurinehate commented Sep 4, 2023

Checklist

mayurinehate Sep 4, 2023

Choose a reason for hiding this comment

hsheth2 Sep 5, 2023

Choose a reason for hiding this comment

mayurinehate Sep 6, 2023

Choose a reason for hiding this comment

mayurinehate Sep 4, 2023 • edited

Choose a reason for hiding this comment

mayurinehate Sep 4, 2023

Choose a reason for hiding this comment

hsheth2 Sep 5, 2023

Choose a reason for hiding this comment

hsheth2 Sep 5, 2023

Choose a reason for hiding this comment

mayurinehate Sep 4, 2023 •

edited