Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/dbt-cloud): use job-based graphql queries #8647

Merged
merged 1 commit into from
Aug 17, 2023
Merged

feat(ingest/dbt-cloud): use job-based graphql queries #8647

merged 1 commit into from
Aug 17, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 16, 2023

The old type-based ones will be deprecated on Sept 7.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(ingest/dbt-cloud): use job-based graphql queries
57e45bc 
The old type-based ones will be deprecated on Sept 7.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 16, 2023
asikowitz
asikowitz approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar here but looks reasonable

@asikowitz
Copy link
Collaborator

Merging as FAILED tests/integration/vertica/test_vertica.py looks unrelated

@asikowitz asikowitz merged commit c5a2e89 into datahub-project:master Aug 17, 2023
42 of 44 checks passed
@asikowitz asikowitz deleted the dbt-cloud-deprecation branch August 17, 2023 17:29
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@hsheth2 @asikowitz
feat(ingest/dbt-cloud): use job-based graphql queries (datahub-projec…
6042e3c 
…t#8647)
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@hsheth2 @yoonhyejin
feat(ingest/dbt-cloud): use job-based graphql queries (#8647)
54e7af8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz