Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(ingest): make ingestion caching rules correct #8685

Merged
merged 2 commits into from
Aug 24, 2023
Merged

ci(ingest): make ingestion caching rules correct #8685

merged 2 commits into from
Aug 24, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 22, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 22, 2023
shirshanka
shirshanka approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failures are not related

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@hsheth2 hsheth2 mentioned this pull request Aug 22, 2023
Merged
5 tasks
@hsheth2 hsheth2 merged commit 090f8af into datahub-project:master Aug 24, 2023
51 of 53 checks passed
@hsheth2 hsheth2 deleted the ingest-cache branch August 24, 2023 05:06
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@hsheth2 @yoonhyejin
ci(ingest): make ingestion caching rules correct (#8685)
663195c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsheth2 @shirshanka @anshbansal