Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Update ownership-types image urls #8905

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 26, 2023

Updates ownership type documentation image urls to map to the main branch.
There is a possible concern that this may break v0.10.5 documentation if we delete the branch behind this PR: datahub-project/static-assets#40

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Updates ownership type documentation image urls to map to the main branch.
@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 26, 2023

@pedro93 it was previously a commit hash, so deleting the branch should be fine

@hsheth2 hsheth2 merged commit ca4dc4e into master Sep 26, 2023
3 checks passed
@hsheth2 hsheth2 deleted the ps-ownership-images branch September 26, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants