Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor appendtone signature" #7

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Revert "Refactor appendtone signature" #7

merged 1 commit into from
Oct 23, 2017

Conversation

datajerk
Copy link
Owner

Reverts #6

Tests failed.

@datajerk datajerk merged commit c85a352 into master Oct 23, 2017
@datajerk
Copy link
Owner Author

LOAD ERRERR just getting started.

@raphlinus
Copy link
Contributor

I'm trying to install a test environment so I can run these myself. Test failure was not expected, I'm curious what went wrong.

@datajerk
Copy link
Owner Author

Error happens immediately when trying to load the standard 1333 bps protocol, ERR is from the ROM. I do not have the time to compare waveforms of working vs. non-working until later tonight.

@raphlinus
Copy link
Contributor

Yeah, I've got it figured out, the dsk path sets the rate to 48000 but that happens after outbuf_init, so the rates mismatched. I've got it working locally.

@datajerk
Copy link
Owner Author

did you want to send a new PR?

@raphlinus
Copy link
Contributor

Yes, I'll send it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datajerk @raphlinus