-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --caching
option (off by default)
#104
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 90.93% 90.72% -0.22%
==========================================
Files 10 10
Lines 596 604 +8
==========================================
+ Hits 542 548 +6
- Misses 54 56 +2 ☔ View full report in Codecov by Sentry. |
1629955
to
cb1e3e8
Compare
Great, thank you! could you please
|
@yarikoptic Done. |
with fusing(ds.path, tmp_path, transparent=transparent, wait=True) as mount: | ||
with fusing( | ||
ds.path, tmp_path, caching=True, transparent=transparent, wait=True | ||
) as mount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have ideas why codecov claims that we are loosing now coverage of the cache-clear
?
https://app.codecov.io/gh/datalad/datalad-fuse/pull/104/blob/datalad_fuse/fsspec_cache_clear.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. It doesn't appear we ever tested that command to begin with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed... odd... I reran with this patch and did not spot traceback from being printed :-/
diff --git a/datalad_fuse/fsspec_cache_clear.py b/datalad_fuse/fsspec_cache_clear.py
index 60fcfbb..10d726b 100644
--- a/datalad_fuse/fsspec_cache_clear.py
+++ b/datalad_fuse/fsspec_cache_clear.py
@@ -1,3 +1,5 @@
+import sys
+import traceback
from typing import Any, Dict, Iterator, Optional
from datalad.distribution.dataset import (
@@ -42,6 +44,7 @@ class FsspecCacheClear(Interface):
def __call__(
dataset: Optional[Dataset] = None, recursive: bool = False
) -> Iterator[Dict[str, Any]]:
+ traceback.print_stack(file=sys.stderr)
ds = require_dataset(
dataset, purpose="clear fsspec cache", check_installed=True
)
Closes #103.