Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial attempt at fixing Benchmark workflow #105

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Partial attempt at fixing Benchmark workflow #105

merged 2 commits into from
Feb 19, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 19, 2024

It appears that asv 0.6.2 does the wrong thing in regards to fulfilling the setuptools >= 30.3.0 build requirement in datalad-fuse's pyproject.toml; specifically, it installs version 30.3.0 of setuptools — rather than the latest version — in the asv environment, causing the build of methodtools (which requires a higher setuptools) to fail. Removing the >= 30.3.0 appears to result in the latest setuptools being installed, but the Benchmark workflow still fails, as it involves testing against the default branch, which still has the >= 30.3.0 specifier.

I'm thus going to merge this and then create a dummy PR to see if the workflow runs successfully there.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cd917b) 90.93% compared to head (28d1b67) 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #105       +/-   ##
===========================================
- Coverage   90.93%   75.00%   -15.94%     
===========================================
  Files          10       10               
  Lines         596      596               
===========================================
- Hits          542      447       -95     
- Misses         54      149       +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder changed the title Dummy PR to test Benchmark workflow Partial attempt at fixing Benchmark workflow Feb 19, 2024
@jwodder jwodder added the tests Add or improve existing tests label Feb 19, 2024
@jwodder jwodder marked this pull request as ready for review February 19, 2024 14:47
@jwodder jwodder merged commit d258f82 into master Feb 19, 2024
11 of 13 checks passed
@jwodder jwodder deleted the dummy branch February 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant