Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATALAD RUNCMD] Make python 3.8 to be minimal python and test with it instead of EOLed 3.7 #108

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

yarikoptic
Copy link
Member

hopefully makes benchmarking working great again

…t instead of EOLed 3.7

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -i -e 's,\\<3.7\\>,3.8,g' .github/workflows/benchmark.yml .github/workflows/docbuild.yml .github/workflows/lint.yml .github/workflows/release.yml .github/workflows/test-libfuse.yml .github/workflows/test.yml .github/workflows/typing.yml setup.cfg",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (c053aeb) to head (076c906).
Report is 10 commits behind head on master.

❗ Current head 076c906 differs from pull request most recent head 25e3ec7. Consider uploading reports for the commit 25e3ec7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   90.72%   91.02%   +0.29%     
==========================================
  Files          10       10              
  Lines         604      624      +20     
==========================================
+ Hits          548      568      +20     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

apparently adding build didn't help. @jwodder - what can you find to have this addressed?

Run asv run --show-stderr --python 3.8 HEAD^-1
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'

in a24e05f you committed

"Don't use asv 0.6.2"

without explanation -- why was that?

@yarikoptic
Copy link
Member Author

ok - PR lead to airspeed-velocity/asv#1389 which is still open, but seems different from above fail

@jwodder
Copy link
Member

jwodder commented Mar 20, 2024

@yarikoptic Is the purpose of this PR just to get benchmarking working, or do you actually want to drop 3.7 support separately from that?

@yarikoptic
Copy link
Member Author

original idea was just on dropping 3.7 since EOLed but indeed then mixed in benchmarking... Let me drop commit for asv so we could just merge 3.7 drop separately and could you troubleshoot/fixup asv in a separate PR?

@yarikoptic yarikoptic merged commit 02200a1 into datalad:master Mar 20, 2024
13 of 15 checks passed
@jwodder
Copy link
Member

jwodder commented Mar 22, 2024

@yarikoptic I tried to get asv working again following the hint the maintainer gave in that issue, but my best guess didn't work. I've posted again on the issue and am awaiting a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants