Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion #197

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

yarikoptic
Copy link
Member

expecting that macos-latest testing would not succeed. We might want to add explicitly macos-12 and then new macos-latest which would be arm

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (d35969d) to head (5d70ec7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   65.69%   65.53%   -0.16%     
==========================================
  Files           1        1              
  Lines        1644     1648       +4     
  Branches      408      409       +1     
==========================================
  Hits         1080     1080              
- Misses        461      465       +4     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic force-pushed the enh-brew branch 2 times, most recently from a9d418a to c753da8 Compare April 25, 2024 01:46
@mslw
Copy link

mslw commented Apr 25, 2024

I think that does it - all checks, including macos-latest, passed.

For additional verification, I tried this in a stripped-out test run on macos-latest (i.e. macos-14-arm64) in a throwaway repo: install the installer from this branch with pip, install git-annex with the installer, install DataLad with pip, and, instead of tests, only run which and ask about versions. It gave me the following, suggesting everything lands correctly on PATH:

/Users/runner/hostedtoolcache/Python/3.11.9/arm64/bin/datalad
/opt/homebrew/bin/git
/opt/homebrew/bin/git-annex
datalad 1.0.2
git version 2.44.0
git-annex version: 10.20240227

I'd say it's good to go.

@yarikoptic yarikoptic changed the title Stripping away no longer needed exclusion + checking on details of brew Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion Apr 25, 2024
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Apr 25, 2024
@yarikoptic yarikoptic marked this pull request as ready for review April 25, 2024 13:53
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Apr 25, 2024
@yarikoptic
Copy link
Member Author

dropped TEMP commit, force pushed, adjusted title to reflect included changes, marking for release.

@yarikoptic yarikoptic merged commit f162b09 into master Apr 25, 2024
36 checks passed
@yarikoptic yarikoptic deleted the enh-brew branch April 25, 2024 14:52
@mslw
Copy link

mslw commented Apr 25, 2024

@yarikoptic the release action crashed - what on earth happened there? https://github.com/datalad/datalad-installer/actions/runs/8834788909/job/24257350453


edit: ok, I think I know. For some reason the release workflow downloads an old version of auto; the issue manifested recently (some change on GitHub side?) and the latest (actually two patches back) release addressed it... Will open an issue with more details or go straight to PR.

@yarikoptic yarikoptic removed the release Create a release when this pr is merged label Apr 25, 2024
@yarikoptic
Copy link
Member Author

merged my "fix" #198 , waiting on result

@mslw
Copy link

mslw commented Apr 25, 2024

I also just realized that the version was simply pinned - I'll keep my fingers crossed 🤞

@yarikoptic
Copy link
Member Author

FWIW -- 1.0.5 was just released so all is good. I am rerunning brew job I had https://github.com/datalad/datalad/actions/runs/8820905835?pr=7586 in datalad/datalad#7586 which if passes is IMHO worth merging to get us 1 step closer there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants