-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion #197
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 65.69% 65.53% -0.16%
==========================================
Files 1 1
Lines 1644 1648 +4
Branches 408 409 +1
==========================================
Hits 1080 1080
- Misses 461 465 +4
Partials 103 103 ☔ View full report in Codecov by Sentry. |
a9d418a
to
c753da8
Compare
I think that does it - all checks, including macos-latest, passed. For additional verification, I tried this in a stripped-out test run on macos-latest (i.e. macos-14-arm64) in a throwaway repo: install the installer from this branch with pip, install git-annex with the installer, install DataLad with pip, and, instead of tests, only run
I'd say it's good to go. |
… for macos-latest
flake8 issued B019 warning about using lru_cache on methods, so moved to a helper function
dropped TEMP commit, force pushed, adjusted title to reflect included changes, marking for release. |
@yarikoptic the release action crashed - what on earth happened there? https://github.com/datalad/datalad-installer/actions/runs/8834788909/job/24257350453 edit: ok, I think I know. For some reason the release workflow downloads an old version of auto; the issue manifested recently (some change on GitHub side?) and the latest (actually two patches back) release addressed it... Will open an issue with more details or go straight to PR. |
merged my "fix" #198 , waiting on result |
I also just realized that the version was simply pinned - I'll keep my fingers crossed 🤞 |
FWIW -- 1.0.5 was just released so all is good. I am rerunning brew job I had https://github.com/datalad/datalad/actions/runs/8820905835?pr=7586 in datalad/datalad#7586 which if passes is IMHO worth merging to get us 1 step closer there |
expecting that macos-latest testing would not succeed. We might want to add explicitly
macos-12
and then newmacos-latest
which would be arm