Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion #197

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Make compatible with arm64 brew, test on older and latest macos, strip away no longer needed windows test env exclusion #197

merged 5 commits into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. Remove useless exclusion (we no longer test pypy-3.7 (since c87497c)

    @yarikoptic
    yarikoptic committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2621fd4 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Test on macos-12 through entire matrix, and only on supported pythons… 

    … for macos-latest
    @yarikoptic
    yarikoptic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7b9ec14 View commit details
    Browse the repository at this point in the history

  2. Define HomebrewInstaller.bin_dir cached_property based on brew --prefix

    @yarikoptic
    yarikoptic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    21f0cd4 View commit details
    Browse the repository at this point in the history

  3. @cached_property is only since 3.8, we still support 3.7 

    flake8 issued B019 warning about using lru_cache on methods, so moved
to a helper function
    @yarikoptic
    yarikoptic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5b09c7f View commit details
    Browse the repository at this point in the history

  4. Fix the test on brew since we could have brew --install call as well

    @yarikoptic
    yarikoptic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5d70ec7 View commit details
    Browse the repository at this point in the history