Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datalad-core's test_wtf fails on main #734

Closed
mih opened this issue Jul 1, 2024 · 3 comments
Closed

datalad-core's test_wtf fails on main #734

mih opened this issue Jul 1, 2024 · 3 comments

Comments

@mih
Copy link
Member

mih commented Jul 1, 2024

From https://ci.appveyor.com/project/mih/datalad-next/build/job/l1hyhxx7pbl4etmx

../../../venv3.8.17/lib/python3.8/site-packages/datalad/local/tests/test_wtf.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
first = 'max_pathlength:'
second = '# WTF\n## configuration \n  - annex.security.allowed-http-addresses: all\n  - annex.security.allowed-url-schemes: htt...x\n  - release: 5.15.0-1057-azure\n  - type: posix\n  - version: #65~20.04.1-Ubuntu SMP Mon Feb 12 17:26:40 UTC 2024\n'
msg = None
    def assert_in(first, second, msg=None):
        if msg is None:
>           assert first in second
E           AssertionError
../../../venv3.8.17/lib/python3.8/site-packages/datalad/tests/utils_pytest.py:104: AssertionError

This is with datalad-1.1.0. Locally (on -next v1.5, also with datalad 1.1.0) I do not see this.

@christian-monch
Copy link
Contributor

christian-monch commented Jul 1, 2024

I opened PR datalad #7628 which should fix the problem.

The faulty code (which has resided in test_wtf for 2 years) is only triggered if psutil is installed (depending on the datalad-version the error is triggered by different versions of psutil).

@adswa
Copy link
Member

adswa commented Jul 24, 2024

Just to keep a record somewhere, the mentioned PR didn't land in core, but datalad/datalad#7622 did, which disables the wtf tests whenever psutil is version 6.0.0 or higher (as it stopped reporting on maxpath from this version onward).

@adswa
Copy link
Member

adswa commented Sep 5, 2024

#751 has been merged, too. I'm closing this.

@adswa adswa closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants