Consistent shell command quoting #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
force-pushed
the
consistent_shell_command_quoting
branch
9 times, most recently
from
3206f05
to
c58347c
Compare
|
The failure on windows seems to be real. |
This commit unifies the quoting of `PurePosixPath`-instances in `datalad_next.shell.operations.posix`. It uses `shlex.quote` to quote stringified `PurePosixPath`-instances.
christian-monch
force-pushed
the
consistent_shell_command_quoting
branch
from
c58347c
to
408fa9b
Compare
christian-monch
force-pushed
the
consistent_shell_command_quoting
branch
from
408fa9b
to
5d5ee93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 92.41% 92.42%
=======================================
Files 193 193
Lines 14108 14121 +13
Branches 2126 2128 +2
=======================================
+ Hits 13038 13051 +13
Misses 808 808
Partials 262 262 ☔ View full report in Codecov by Sentry. |
Yes, I overestimated the capabilities of FAT and NTFS. Everything should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #661
This PR automatically quotes all path parameters provided as
PathorPurePosixPath-instances toshell.posix-functions viashlex.quote.Byte-parameter like the
command-parameter ofShellCommandExecutor.__call__()are never quoted. The caller has to ensure that file names are properly quoted. The are a number of reasons for this policy:bash,PowerShell,Python, etc.bash, there is no way to generally determine whether a path is contained in the command-argument.