Skip to content

Commit

Permalink
More accurate description of the behavior that is patched-away
Browse files Browse the repository at this point in the history
Co-authored-by: Christian Mönch <christian.moench@web.de>
  • Loading branch information
mih and christian-monch committed Sep 20, 2023
1 parent 80dab4a commit c93ece8
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions datalad_ria/patches/ssh_exec.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
``datalad/support/sshconnector.py:BaseSSHConnection._exec_ssh()``
with a dedicated handling of ``stdin`` for Windows.
Without this change, the first remote command execution would succeed,
but upon exit the Python session would somehow "loose" its own ``stdin``
file descriptor.
The OpenSSH client in Windows modifies its ``stdin``-descriptor in such a way, that it becomes unusable for the python process, if the ``stdin``-descriptor is shared between the ``python``-process and the ``ssh``-process. As a result, all read-operations that the ``python``-process performs on ``stdin`` will block and leave the python-process "hanging".
This change passes an explicit, empty, byte-string as ``stdin`` to the
SSH client call, in order to avoid any interaction of SSH with the
Expand Down

0 comments on commit c93ece8

Please sign in to comment.