Skip to content

Commit

Permalink
BF: Do not hide git-push crashes
Browse files Browse the repository at this point in the history
Previous setup assumed that any `git-push` error is an orderly
report that could be forensically analyzed. However, in particular
with custom remote helpers, `git-push` can also just crash, and
there is no guarantee that we can inspect anything.

This is a minimal change that makes sure the `CommandError` bubbles
up, when we know that something is fundamentally not right, because
there was an error, but the expected error message channel is empty.

In all likelihood that is still far from comprehensive, but still better
than before.
  • Loading branch information
mih committed Jul 4, 2020
1 parent 214bdc4 commit 0347258
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion datalad/support/gitrepo.py
Original file line number Diff line number Diff line change
Expand Up @@ -2493,7 +2493,7 @@ def _fetch_push_helper(
if l.startswith('hint: ')])
if output is None:
output = ''
else:
if not output:
raise

for line in output.splitlines():
Expand Down

0 comments on commit 0347258

Please sign in to comment.