Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datalad -c <SOME> needs more sanity checking #3451

Closed
mih opened this issue May 23, 2019 · 0 comments
Closed

datalad -c <SOME> needs more sanity checking #3451

mih opened this issue May 23, 2019 · 0 comments
Labels
fix-implemented A fix is available, but has not been merged or released, yet. UX user experience

Comments

@mih
Copy link
Member

mih commented May 23, 2019

I wanted to do

datalad create -c bids some

but did

datalad -c bids create some

which led to

[INFO   ] Creating a new annex repo at /home/homeGlobal/mih/some 
[ERROR  ] 'NoneType' object has no attribute 'group' [config.py:<listcomp>:438] (AttributeError)

a rather incomprehensible error. I think we should validate the value given to -c and fail immediately, if it does not contain =.
@mih mih added the UX user experience label May 23, 2019
mih added a commit to mih/datalad that referenced this issue Sep 20, 2019
@mih
ENH: Config override spec sanity checks (fixes dataladgh-3451)
011da91 
To prevent us from shooting ourselves in the foot. Without
this change, we could have specified section-less variables
that our own ConfigManager cannot handle, and don't seem to
be supported by Git either.
@mih mih added the fix-implemented A fix is available, but has not been merged or released, yet. label Sep 20, 2019
@mih mih closed this as completed in 36b8c5f Sep 22, 2019
mih added a commit that referenced this issue Sep 22, 2019
@mih
Merge pull request #3695 from mih/bf-cfgoverrides
c7aa628 
ENH: Config override spec sanity checks (fixes gh-3451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-implemented A fix is available, but has not been merged or released, yet. UX user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mih