Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_AnnexRepo_status fails while building/testing on conda-forge #3490

Closed
yarikoptic opened this issue Jun 26, 2019 · 1 comment
Closed
Labels
fix-implemented A fix is available, but has not been merged or released, yet.

Comments

@yarikoptic
Copy link
Member

0.11.5 build
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=44838

======================================================================
FAIL: datalad.support.tests.test_annexrepo.test_AnnexRepo_status
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/datalad_1561498363479/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/conda/feedstock_root/build_artifacts/datalad_1561498363479/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.7/site-packages/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/conda/feedstock_root/build_artifacts/datalad_1561498363479/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.7/site-packages/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/conda/feedstock_root/build_artifacts/datalad_1561498363479/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.7/site-packages/datalad/support/tests/test_annexrepo.py", line 2139, in test_AnnexRepo_status
    _test_status(ar)
  File "/home/conda/feedstock_root/build_artifacts/datalad_1561498363479/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.7/site-packages/datalad/support/tests/test_annexrepo.py", line 1993, in _test_status
    eq_(stat, ar.get_status())
AssertionError: {'untracked': ['fifth', 'sub/third'], 'deleted': [], 'modified': ['first', 'second'], 'added': [], 'type_changed': []} != {'untracked': ['fifth', 'sub/third', 'submod/'], 'deleted': [], 'modified': ['first', 'second'], 'added': [], 'type_changed': []}

so something about submodule submod appearing in untracked.

Versions: appdirs=1.4.3 boto=2.49.0 cmd:annex=7.20190507-g0c2cc3d cmd:git=2.22.0 cmd:system-git=2.22.0 exifread=2.1.2 git=2.1.11 gitdb=2.0.5 humanize=0.5.1 iso8601=0.1.12 keyring=19.0.2 keyrings.alt=3.1 msgpack=0.6.1 mutagen=1.41.1 patoolib=1.12 requests=2.22.0 six=1.12.0 tqdm=4.32.2 wrapt=1.11.2

so may be new git 2.22.0? updated to 1:2.22.0+next.20190617-1 from experimental, still passed:

$> python -m nose -s -v datalad/support/tests/test_annexrepo.py:test_AnnexRepo_status
datalad.support.tests.test_annexrepo.test_AnnexRepo_status ... ok
Versions: appdirs=1.4.3 boto=2.44.0 cmd:annex=7.20190507+git126-g5d681a3ce-1~ndall+1 cmd:git=2.20.1 cmd:system-git=2.22.0.455.g172b71a6c5 cmd:system-ssh=7.9p1 exifread=2.1.2 git=2.1.11 gitdb=2.0.5 humanize=0.5.1 iso8601=0.1.11 keyring=17.1.1 keyrings.alt=3.1.1 msgpack=0.5.6 mutagen=1.40.0 requests=2.21.0 six=1.12.0 wrapt=1.10.11
Obscure filename: str=b' "\';a&b&c\xce\x94\xd0\x99\xd7\xa7\xd9\x85\xe0\xb9\x97\xe3\x81\x82 `| ' repr=' "\';a&b&cΔЙקم๗あ `| '
Encodings: default='utf-8' filesystem='utf-8' locale.prefered='UTF-8'
Environment: PATH='/home/yoh/proj/datalad/datalad/venvs/dev3/bin:/home/yoh/gocode/bin:/home/yoh/gocode/bin:/home/yoh/bin:/home/yoh/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/snap/bin:/sbin:/usr/sbin:/usr/local/sbin' LANG='en_US.utf8' GIT_PAGER='less --no-init --quit-if-one-screen' GIT_PYTHON_GIT_EXECUTABLE='/usr/lib/git-annex.linux/git'

remembered that we are using bundled with annex git, so tried to force system one way and it also passed

$> DATALAD_USE_DEFAULT_GIT=1 python -m nose -s -v datalad/support/tests/test_annexrepo.py:test_AnnexRepo_status 
datalad.support.tests.test_annexrepo.test_AnnexRepo_status ... ok
Versions: appdirs=1.4.3 boto=2.44.0 cmd:annex=7.20190507+git126-g5d681a3ce-1~ndall+1 cmd:git=2.22.0.455.g172b71a6c5 cmd:system-git=2.22.0.455.g172b71a6c5 cmd:system-ssh=7.9p1 exifread=2.1.2 git=2.1.11 gitdb=2.0.5 humanize=0.5.1 iso8601=0.1.11 keyring=17.1.1 keyrings.alt=3.1.1 msgpack=0.5.6 mutagen=1.40.0 requests=2.21.0 six=1.12.0 wrapt=1.10.11
Obscure filename: str=b' "\';a&b&c\xce\x94\xd0\x99\xd7\xa7\xd9\x85\xe0\xb9\x97\xe3\x81\x82 `| ' repr=' "\';a&b&cΔЙקم๗あ `| '
Encodings: default='utf-8' filesystem='utf-8' locale.prefered='UTF-8'
Environment: PATH='/home/yoh/proj/datalad/datalad/venvs/dev3/bin:/home/yoh/gocode/bin:/home/yoh/gocode/bin:/home/yoh/bin:/home/yoh/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/snap/bin:/sbin:/usr/sbin:/usr/local/sbin' LANG='en_US.utf8' GIT_PAGER='less --no-init --quit-if-one-screen'

----------------------------------------------------------------------
Ran 1 test in 5.045s

also this failure was not observed in #3476 testing against 0.22.0 - https://travis-ci.org/datalad/datalad/builds/550815965?utm_source=github_status&utm_medium=notification
so not yet sure what is the cause for the regression (or some change in conda-forge build env starting to trigger it).

@kyleam
Copy link
Contributor

kyleam commented Jun 26, 2019

This should also be related to Git's change in treatment of repos with no commit checked out.

also this failure was not observed in #3476 testing against 0.22.0 -

That made me scratch my head, too, but it looks like that is because this test is only in 0.11.x.

I'll have a look.

kyleam added a commit to kyleam/datalad that referenced this issue Jun 26, 2019
As of Git 2.22.0, specifically b22827045e (dir: do not traverse
repositories with no commits, 2019-04-09), 'git ls-files' now treats a
repository on an unborn branch as a repository rather than a
directory.

Fixes datalad#3490.
@kyleam kyleam added the fix-implemented A fix is available, but has not been merged or released, yet. label Jun 26, 2019
kyleam added a commit to kyleam/datalad that referenced this issue Jun 26, 2019
As of Git 2.22.0, specifically b22827045e (dir: do not traverse
repositories with no commits, 2019-04-09), 'git ls-files' now treats a
repository on an unborn branch as a repository rather than a
directory.

Fixes datalad#3490.
@kyleam kyleam closed this as completed in f2c8f7f Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented A fix is available, but has not been merged or released, yet.
Projects
None yet
Development

No branches or pull requests

2 participants