Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized gitrepo cloning broken on win10 #3639

Closed
mih opened this issue Sep 1, 2019 · 4 comments · Fixed by #3979
Closed

Optimized gitrepo cloning broken on win10 #3639

mih opened this issue Sep 1, 2019 · 4 comments · Fixed by #3979
Labels
crippled-filesystems Issue concerned with operation on crippled filesystems, regardless of OS platform-windows Issue concerned with Windows severity-normal standard severity

Comments

@mih
Copy link
Member

mih commented Sep 1, 2019

Originally reported in #3635. Making it a separate issue, because the test will be disabled on win in order to make progress on more important issues.

This issue is legit, inodes seem to be reported properly, but do not match.

======================================================================
FAIL: datalad.support.tests.test_gitrepo.test_optimized_cloning
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\mih\Miniconda3\lib\site-packages\nose\case.py", line 198, in runTest
    self.test(*self.arg)
  File "c:\users\mih\code\datalad\datalad\tests\utils.py", line 607, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "c:\users\mih\code\datalad\datalad\support\tests\test_gitrepo.py", line 1161, in test_optimized_cloning
    eq_(origin_inodes, clone_inodes, msg='with src={}'.format(src))
AssertionError: with src=file:///C%3A/Users/mih/AppData/Local/Temp/datalad_temp_xfuka682/origin
@mih mih added the platform-windows Issue concerned with Windows label Sep 1, 2019
mih added a commit to mih/datalad that referenced this issue Jan 2, 2020
The new 'compatibility' argument of get_local_file_url() is relatively
painless and the workaround implementation can be removed (and the
argument rendered into a no-op) if there should be a compatibility
fix at the git-annex end.

Fixes dataladgh-3639
@mih mih closed this as completed in #3979 Jan 3, 2020
@mih mih added severity-normal standard severity and removed platform-windows Issue concerned with Windows labels Jul 15, 2020
@mih
Copy link
Member Author

mih commented Jul 15, 2020

This is not just a windows issue, but affects crippled FS as well.

======================================================================
FAIL: datalad.support.tests.test_gitrepo.test_optimized_cloning
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mih/env/datalad3-dev/lib/python3.7/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/mih/hacking/datalad/git/datalad/tests/utils.py", line 187, in newfunc
    return func(*args, **kwargs)
  File "/home/mih/hacking/datalad/git/datalad/tests/utils.py", line 715, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/mih/hacking/datalad/git/datalad/support/tests/test_gitrepo.py", line 1152, in test_optimized_cloning
    eq_(origin_inodes, clone_inodes, msg='with src={}'.format(src))
AssertionError: with src=/media/mih/Samsung_T5/tmp/datalad_temp_test_optimized_cloningby6pyqhk/origin

Revealed via gh-4708

@mih mih reopened this Jul 15, 2020
@mih mih added the crippled-filesystems Issue concerned with operation on crippled filesystems, regardless of OS label Jul 15, 2020
@mih mih added the platform-windows Issue concerned with Windows label Oct 13, 2020
@yarikoptic
Copy link
Member

FWIW, on a verge of 2022 we still have that test disabled on windows

(git)lena:~datalad/datalad-maint[maint]git
$> git grep -4 test_optimized_cloning
datalad/support/tests/test_gitrepo.py-# this is simply broken on win, but less important
datalad/support/tests/test_gitrepo.py-# https://github.com/datalad/datalad/issues/3639
datalad/support/tests/test_gitrepo.py-@skip_if_on_windows
datalad/support/tests/test_gitrepo.py-@with_tempfile
datalad/support/tests/test_gitrepo.py:def test_optimized_cloning(path):

so it is 50/50 chance it still exists! ;-)

@mih
Copy link
Member Author

mih commented Nov 2, 2021

Confirm to still be happening on crippled FS.

@mih
Copy link
Member Author

mih commented Nov 24, 2022

Closing this old issue of mine. In three years at has never made a priority level that led to actual fixes.

@mih mih closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crippled-filesystems Issue concerned with operation on crippled filesystems, regardless of OS platform-windows Issue concerned with Windows severity-normal standard severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants