Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.11.3 release #3167

Closed
wants to merge 4 commits into from
Closed

Prepare 0.11.3 release #3167

wants to merge 4 commits into from

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Feb 15, 2019

Since 0.11.2
# Generated with
#   git log --format="?  %s%n   %h^-1" --reverse --first-parent 0.11.2..origin/master
#
#
# ?  = unprocessed and undecided
# -  = decided not to include
# +  = included
# +* = included, but might still be bits that should be added

-  Merge remote-tracking branch 'gh-yarikoptic/rel-0.11.2'
   c797f719c^-1
-  Show must go on
   ca3225e66^-1
-  Merge pull request #3145 from kyleam/tst-protocol-callable
   137da7087^-1
-  Merge pull request #3160 from yarikoptic/bf-tests
   f1ebdac30^-1
+  Merge pull request #3156 from yarikoptic/bf-delayed-datasetmethod
   81bfe17a7^-1
+  Merge pull request #3165 from yarikoptic/bf-python34-long
   9c6f6ab82^-1
-  Merge pull request #3166 from yarikoptic/bf-disable-appveyor-installtest
   95ac85b42^-1
+  BF: Allow datalad commands not requiring git-annex changes to operate on read-only filesystem
   4eff996c8^-1
+  ENH: ssh: Support specifying identity file via datalad.ssh.identityfile config variable
   cf3f899e5^-1

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./tools/link_issues_CHANGELOG",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@kyleam
Copy link
Contributor Author

kyleam commented Feb 15, 2019

Er, these are merge commits: 4eff996 (BF: Allow datalad commands not requiring git-annex changes to operate on read-only filesystem, 2019-02-15) and 4eff996 (BF: Allow datalad commands not requiring git-annex changes to operate on read-only filesystem, 2019-02-15).

Guess GitHub has changed their style of the default merge subject?

@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #3167 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3167      +/-   ##
=========================================
+ Coverage    90.8%   90.8%   +<.01%     
=========================================
  Files         249     249              
  Lines       32781   32784       +3     
=========================================
+ Hits        29766   29769       +3     
  Misses       3015    3015
Impacted Files Coverage Δ
datalad/support/sshconnector.py 85.02% <0%> (-0.08%) ⬇️
datalad/support/tests/test_sshconnector.py 99.29% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3f899...5c310ac. Read the comment docs.

@yarikoptic
Copy link
Member

Nope, I changed the way I did merges today.
Sounds we may be always adjust summary line you merge?

@kyleam
Copy link
Contributor Author

kyleam commented Feb 16, 2019

Nope, I changed the way I did merges today

Oh, I see. I've witnessed a trail being blazed.

Sounds we may be always adjust summary line you merge?

I can't parse that.

@yarikoptic
Copy link
Member

sorry -- was on the phone and laptop fix was still being WiP (recent fall to the floor broke one of the screen hinges a bit). What I meant is that may be we should set a habbit to adjust all merge messages to be close to the ones we want to see in the changelog?
Also I have merged #3168 now - would you mind tuning the changelog if you like and then I will prep/kick out the release (after having built debian packages which often brings some surprises)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./tools/link_issues_CHANGELOG",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@kyleam
Copy link
Contributor Author

kyleam commented Feb 16, 2019

sorry -- was on the phone and laptop fix was still being WiP (recent fall to the floor broke one of the screen hinges a bit).

Oh, poor laptop :[

What I meant is that may be we should set a habbit to adjust all merge messages to be close to the ones we want to see in the changelog?

No, please use whatever form you prefer. For my changelog purposes, they are fine because they're picked out just the same by git log --reverse --first-parent ....

Also I have merged #3168 now

Thanks!

  • would you mind tuning the changelog if you like

Done (just linked to the second PR number).

@yarikoptic
Copy link
Member

Will do touchups locally, thank you @kyleam !

@yarikoptic yarikoptic closed this Feb 18, 2019
@kyleam kyleam deleted the prepare-0.11.3 branch February 20, 2019 18:39
@yarikoptic yarikoptic mentioned this pull request Mar 1, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants