Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix execution of patool commands #3176

Merged
merged 6 commits into from
Feb 25, 2019

Commits on Feb 22, 2019

  1. ENH(TST,BK): test ability to compress/extract .gz

    BK since would stall if gzip or pigz is available, and not p7zip
    yarikoptic committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    5bbd5ef View commit details
    Browse the repository at this point in the history
  2. ENH(TST): test running with shell, comment that cmd as list + shell=T…

    …rue is probably not what you want
    yarikoptic committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    840dac9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ae6731 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. BF: convert patool's run cmd list into a string

    patool invokes with shell=True and behavior when cmd is provided as list
    and shell is True is not what you would expect - only the first list member
    is provided to the shell and the rest as additional arguments to the shell,
    not as a part of the command. That leads to incorrect execution of the line
    yarikoptic committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    8903062 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. RF/ENH(TST): test that extracted .gz file retains original name

    This test passes whenever p7zip-full is installed
    yarikoptic committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    9359f83 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. BF(workaround): blow when extracting .gz if no 7z available for now

    Proper solution is a bit too involved, so postponed, and decided just to blow
    with an informative message for now
    yarikoptic committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    06ab803 View commit details
    Browse the repository at this point in the history