Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh-3621 broken error handling under PY3 #3622

Merged
merged 6 commits into from Aug 26, 2019
Merged

Fix gh-3621 broken error handling under PY3 #3622

merged 6 commits into from Aug 26, 2019

Commits on Aug 26, 2019

  1. BF: Move conditional (back) inside except (fixes dataladgh-3621) 

    Mere move, indent, reformat.
    @mih
    mih committed Aug 26, 2019
    Copy the full SHA
    bd975a8 View commit details
    Browse the repository at this point in the history

  2. RF: Discontinue evil 'import *'

    @mih
    mih committed Aug 26, 2019
    Copy the full SHA
    22392dd View commit details
    Browse the repository at this point in the history

  3. RF: Adjust import location 

    Formerly exceptions had been imported blindly into downloaders.base
There seems to be no advantage of having 'import *' at the core, and
then specific imports downstream.
    @mih
    mih committed Aug 26, 2019
    Copy the full SHA
    9c8a3a8 View commit details
    Browse the repository at this point in the history

  4. RF: Adjust import locations, round 2 

    These locations were missed by the last commit.
    @kyleam
    kyleam committed Aug 26, 2019
    Copy the full SHA
    24a99f0 View commit details
    Browse the repository at this point in the history

  5. RF: downloaders: Add missing import 

    This one was missed in 22392dd (RF: Discontinue evil 'import *',
2019-08-26).
    @kyleam
    kyleam committed Aug 26, 2019
    Copy the full SHA
    876751b View commit details
    Browse the repository at this point in the history

  6. RF: downloaders: Remove unneeded condition 

    As of bd975a8, this code is under the AccessDeniedError exception
handling, so the access_denied flag is no longer needed.
    @kyleam
    kyleam committed Aug 26, 2019
    Copy the full SHA
    8d1a72e View commit details
    Browse the repository at this point in the history