Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible clone URL generation for submodules #3828

Merged
merged 14 commits into from
Oct 28, 2019

Commits on Oct 23, 2019

  1. RF: Replace custom git branch call with preferable git for-each-ref

    For which our wrapper had to be extended. One could argue that
    `.call_git_items_()` would be at least as adequate, but I chose to
    invest in my prior investments ;-)
    mih committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    f0f5926 View commit details
    Browse the repository at this point in the history
  2. RF: Relocate single-use internal helper for get()

    The desire is to slim the interface.
    mih committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    9424aeb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf32550 View commit details
    Browse the repository at this point in the history
  4. RF: get_last_commit_hash() -> get_last_commit_hexsha()

    To align with get_hexsha()
    mih committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    62773e6 View commit details
    Browse the repository at this point in the history
  5. BF: Turn no longer valid error handling into a plain conditional

    No StopIteration could have come out of that code block
    mih committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    116d611 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ac84c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Configuration menu
    Copy the full SHA
    2650455 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd7ba6a View commit details
    Browse the repository at this point in the history
  3. ENH: Introduce names for candidate clone URLs

    This touches upon an idea by @yaricoptic expressed in
    datalad#3827 (comment)
    and merely lays the foundation for further work.
    
    Names are not unique (and I don't see how they could be, or what we
    would gain from it), hence no dict.
    
    Choice of names is debatable too. But given that they are not used ATM,
    it doesn't really matter and can easily be changed.
    mih committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    8e99c2f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1c2a659 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. DOC: get: Fix some recent docstring typos

    [ci skip]
    kyleam committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    7eac837 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. RF: Use 'local' label for gitmodule URL configured for a local submodule

    Following a suggestion from @kyleam
    mih committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    e565841 View commit details
    Browse the repository at this point in the history
  2. ENH: Rebustify error detection

    Thanks @kyleam
    mih committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    96b88fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad04e53 View commit details
    Browse the repository at this point in the history