Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: No GitPython use in publish #4171

Merged
merged 2 commits into from Feb 20, 2020
Merged

RF: No GitPython use in publish #4171

merged 2 commits into from Feb 20, 2020

Conversation

mih
Copy link
Member

@mih mih commented Feb 20, 2020

Sits on top of #3834 because it needs get_branch_commits() to return string hex SHAs.

mih added 2 commits Feb 20, 2020
and add '_' function name suffix to indicate its generator-behavior.

This furthers datalad#2970
@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #4171 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   89.13%   89.17%   +0.04%     
==========================================
  Files         275      275              
  Lines       35847    35825      -22     
==========================================
- Hits        31953    31948       -5     
+ Misses       3894     3877      -17     
Impacted Files Coverage Δ
datalad/support/tests/test_annexrepo.py 95.57% <0.00%> (+0.32%) ⬆️
datalad/downloaders/base.py 75.55% <0.00%> (+0.37%) ⬆️
datalad/downloaders/http.py 74.10% <0.00%> (+0.39%) ⬆️
datalad/downloaders/tests/test_http.py 61.80% <0.00%> (+1.21%) ⬆️
datalad/support/tests/utils.py 96.15% <0.00%> (+11.53%) ⬆️
datalad/support/tests/test_cookies.py 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc05be3...73b62f1. Read the comment docs.

kyleam
kyleam approved these changes Feb 20, 2020
Copy link
Contributor

@kyleam kyleam left a comment

Sits on top of #3834 because it needs get_branch_commits() to return string hex SHAs.

I already commented that the changes from gh-3834 look fine to me. The new changes here do too.

@mih mih merged commit 07c5eee into datalad:master Feb 20, 2020
16 of 17 checks passed
@mih mih deleted the rf-nogitpypublish branch Feb 20, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants