ENH: Expose diff_dataset() and add reporting_order parameter. #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make a faster diff with `eval_file_type=True` accessible to internal users (like `push()`). `reporting_order` enables more flexible applications. While the past and current default `depth-first` is most suitable for human-readable reporting, the alternative `breadth-first` enables straightforward consolidation of all diff reports for a dataset (incl. all submodule records) into an uninterupted series of results. This simplies client code that needs to investigate a complete changes set of a dataset, and aims to yield its conclusions immediately, in order to kick of further processing (generator-style) -- useful for effective parallelization.
Makes sense, though there's a bug in the |
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #4229 +/- ##
==========================================
- Coverage 89.23% 89.16% -0.08%
==========================================
Files 275 275
Lines 36250 36317 +67
==========================================
+ Hits 32348 32381 +33
- Misses 3902 3936 +34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make a faster diff with
eval_file_type=Trueaccessible tointernal users (like
push()).reporting_orderenables more flexible applications. While the past andcurrent default
depth-firstis most suitable for human-readablereporting, the alternative
breadth-firstenables straightforwardconsolidation of all diff reports for a dataset (incl. all submodule
records) into an uninterrupted series of results. This simplies client
code that needs to investigate a complete changes set of a dataset, and
aims to yield its conclusions immediately, in order to kick of further
processing (generator-style) -- useful for effective parallelization.
Split from #4206
TODO: