-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: specify push
--data modes; keep --force
to only force git push and checkdatapresent
#4620
Commits on Jun 9, 2020
-
RF: push - introduce --transfer-data=(anything|nothing|auto)
Changes are intensionally minimal. Subsequent commits might refine further
Configuration menu - View commit details
-
Copy full SHA for c6d032c - Browse repository at this point
Copy the full SHA c6d032cView commit details -
RF: define force_git_push helper var at _push level
I am luke warm about this change -- just wanted to compartmentalize "forces" to _push instead of spreading logic around all helper functions
Configuration menu - View commit details
-
Copy full SHA for a0a8cd1 - Browse repository at this point
Copy the full SHA a0a8cd1View commit details -
[DATALAD RUNCMD] RF: --force=datatransfer -> --force=checkdatapresent…
… (to be more to the point of the effect) Closes datalad#4603 === Do not change lines below === { "chain": [], "cmd": "git-sedi datatransfer checkdatapresent", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [ "datalad/core/distributed/push.py", "datalad/core/distributed/tests/test_push.py" ], "pwd": "." } ^^^ Do not change lines above ^^^
Configuration menu - View commit details
-
Copy full SHA for b20ed13 - Browse repository at this point
Copy the full SHA b20ed13View commit details -
[DATALAD RUNCMD] RF: --force=pushall -> --force=all (since now could …
…just enable all forces - orthogonal) === Do not change lines below === { "chain": [], "cmd": "git-sedi pushall all", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [ "datalad/core/distributed/push.py", "datalad/core/distributed/tests/test_push.py" ], "pwd": "." } ^^^ Do not change lines above ^^^
Configuration menu - View commit details
-
Copy full SHA for 65aae48 - Browse repository at this point
Copy the full SHA 65aae48View commit details -
DOC: adjust --force docstring to be more to the point of the effects
Any option is about changing "automatic decision making" IMHO. I think it is important to mention possible effects such as absence of --force for push is a safety measure. Default --fast is optimization and name "checkdatapresent" is self descriptive on the effect
Configuration menu - View commit details
-
Copy full SHA for 3492d60 - Browse repository at this point
Copy the full SHA 3492d60View commit details -
RF: --transfer-data=auto-if-wanted which dissolves datalad.push.copy-…
…auto-if-wanted config I was going back and forth either we need some additional "datalad.push.transfer-data" config setting which could be set per repository to indicate what "datalad push" should do with data. But I remain of an idea that it would be counter-productive to establish yet another level of data transfer behavior instead of using what is already there provided by git-annex itself. To maintain "do the right thing" behavior by default I had decided also to make auto-if-wanted to be the default mode of operation -- it will transfer data if there is no explicit "wanted" setting for the remote.
Configuration menu - View commit details
-
Copy full SHA for 1be419f - Browse repository at this point
Copy the full SHA 1be419fView commit details -
ENH: log at debug that we do not even attempt data transfer is not gi…
…t-annex To ease possible troubleshooting later on whenever some expected data transfer does not happen. Also tuned up a comment to say "copy" not "move", which is a valid (but not supported ATM) operation.
Configuration menu - View commit details
-
Copy full SHA for 8031fbb - Browse repository at this point
Copy the full SHA 8031fbbView commit details
Commits on Jun 12, 2020
-
[DATALAD RUNCMD] RF: push - --transfer-data -> --data
=== Do not change lines below === { "chain": [], "cmd": "sed -i -e 's,transfer_data,data,g' -e 's,--transfer-data,--data,g' {outputs}", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [ "datalad/core/distributed/push.py", "datalad/core/distributed/tests/test_push.py" ], "pwd": "." } ^^^ Do not change lines above ^^^
Configuration menu - View commit details
-
Copy full SHA for 7dd99fd - Browse repository at this point
Copy the full SHA 7dd99fdView commit details
Commits on Jun 15, 2020
-
ENH: RM note about anything/nothing, duplicate "data"
Also placed list of constraints to a new line to make it fit 80 chars
Configuration menu - View commit details
-
Copy full SHA for 56fd2e8 - Browse repository at this point
Copy the full SHA 56fd2e8View commit details
Commits on Jun 18, 2020
-
TST: push: Add test for data="auto"
Adapt the test posted at dataladgh-4541. Aside from tweaking the way to specify "use --auto", add a block that tests that the following two behave the same when a file does not match a remote's preferred content: datalad push --to=r --data=auto FILE git annex copy --to=r --auto FILE
Configuration menu - View commit details
-
Copy full SHA for 38ba64b - Browse repository at this point
Copy the full SHA 38ba64bView commit details
Commits on Jun 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 20d80cf - Browse repository at this point
Copy the full SHA 20d80cfView commit details -
TST: push: Skip create-sibling-dependent tests on crippled FS
We already do this elsewhere in test_push.py, because running the post-update hooks fails. Example: https://ci.appveyor.com/project/mih/datalad/builds/33609947/job/8ylv5wpq7l2fn93p#L1061
Configuration menu - View commit details
-
Copy full SHA for 0646464 - Browse repository at this point
Copy the full SHA 0646464View commit details