Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for testing on macOS #4947

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Workflow for testing on macOS #4947

merged 2 commits into from
Sep 22, 2020

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 22, 2020

Closes #4942.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #4947 into maint will decrease coverage by 0.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4947      +/-   ##
==========================================
- Coverage   89.68%   89.67%   -0.02%     
==========================================
  Files         289      289              
  Lines       40488    40500      +12     
==========================================
+ Hits        36312    36317       +5     
- Misses       4176     4183       +7     
Impacted Files Coverage Δ
datalad/tests/utils.py 86.51% <30.00%> (-0.64%) ⬇️
datalad/core/distributed/tests/test_push.py 97.98% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021aa5f...83adb0f. Read the comment docs.

@yarikoptic
Copy link
Member

Great. Please add known_failure_githubci_osx similar to known_failure_githubci_win and decorate those two failing tests with it so we get green at least and proceed. IMHO ideally this one should be positioned against maint branch (not master) since would be of benefit there.

@jwodder jwodder changed the base branch from master to maint September 22, 2020 20:05
@jwodder
Copy link
Member Author

jwodder commented Sep 22, 2020

@yarikoptic Done.

@yarikoptic
Copy link
Member

I think more green runs is good, so I will proceed with merge.
Could you please try to add codecov submission in a follow up PR? There was something not working for windows workflow https://github.com/datalad/datalad/blob/master/.github/workflows/test_win2019_disabled#L59 but may be it would work for osx?

@yarikoptic yarikoptic merged commit a2e70de into datalad:maint Sep 22, 2020
@jwodder jwodder deleted the gh-4942 branch November 21, 2020 02:57
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github workflow to test on OSX
2 participants