-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Runner #5229
Remove old Runner #5229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5229 +/- ##
==========================================
+ Coverage 89.72% 89.97% +0.25%
==========================================
Files 301 297 -4
Lines 42413 41573 -840
==========================================
- Hits 38054 37407 -647
+ Misses 4359 4166 -193
Continue to review full report at Codecov.
|
Fixes dataladgh-5003 [skip ci]
Made obsolete by GitWitlessRunner.run_on_file_list_chunks()
This prevents one of the travis runs to exceeds max log size. This is a test-battery-only problem, because `AnnexRepo.add_urls()` is not used outside the tests (datalad#5153), and the plan is to get rid of it eventually (datalad#5153 (comment)).
This can happen, without being an indication of an error, when I command like `whereis --json` legitimately produces no results, but at the same time git-annex runs in debug mode (which can be automatically triggered via log-level). But what would be an indication of trouble is stdout content, that wasn't parsed to JSON records.
git-annex stderr will not be empty when in debug mode.
test_annexjson_protocol() fails when executed under DATALAD_LOG_LEVEL=8 because git-annex is called with --debug when `getEffectiveLevel() <= 8` while the condition in the previous commit treats it as `getEffectiveLevel() <= 7`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm very happy to see this. All the commits look good to me (with a boundary fixup pushed for "BF: Rectify test assumption").
Subject: [PATCH 2/6] RF: Remove run_gitcommand_on_file_list_chunks()
Made obsolete by GitWitlessRunner.run_on_file_list_chunks()
Dropping it right away, rather than leaving it around with a DeprecationWarning, is fine with me. It seems unlikely to be used by outside callers, and a quick search across known extensions and on github doesn't bring up anything.
Oy, I just now clicked through to the crawler failure. It has a good number of import errors, which I think are all coming from this part of from datalad.cmd import Runner
from datalad.support.protocol import DryRunProtocol
def get_runner(*args, **kwargs):
if cfg.obtain('datalad.crawl.dryrun', default=False):
kwargs = kwargs.copy()
kwargs['protocol'] = DryRunProtocol()
return Runner(*args, **kwargs) https://github.com/datalad/datalad/pull/5229/checks?check_run_id=1538522651 |
@@ -66,131 +63,6 @@ def get_function_nargs(f): | |||
return len(argspec.args) - 1 | |||
|
|||
|
|||
class AnnexExchangeProtocol(ProtocolInterface): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bye bye my Dear friend, you were a good help! I can only hope that I will not miss you, in log and Joey we trust!
I started a PR to perform the necessary RF: datalad/datalad-crawler#89 |
@yarikoptic has merged the crawler fix. thx! All good now! |
OK, this is it! I hope the fall-out over the coming days is not to intense, but I think it is good to merge this now and give it sufficient time to let the dust settle before a 0.14. Thanks for all the bits you contributed over the years 👀 to make this possible. Witless we will be from now . |
Fixed #5003