Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions action versions #7082

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 12, 2022

We are currently using older versions of the updated GitHub Actions actions, and these older versions still use Node 12, which is deprecated.

This PR also configures Dependabot to create PRs updating workflows whenever a new version of a used action is released, as discussed in datalad/datalad-extensions#105.

@jwodder jwodder added semver-internal Changes only affect the internal API CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Oct 12, 2022
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 74.88% // Head: 76.01% // Increases project coverage by +1.12% 🎉

Coverage data is based on head (dccc798) compared to base (18f0bf9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7082      +/-   ##
==========================================
+ Coverage   74.88%   76.01%   +1.12%     
==========================================
  Files         355      355              
  Lines       59101    59101              
  Branches     6318     6318              
==========================================
+ Hits        44260    44925     +665     
+ Misses      14827    14162     -665     
  Partials       14       14              
Impacted Files Coverage Δ
datalad/_version.py 45.68% <0.00%> (-0.28%) ⬇️
datalad/__init__.py 86.00% <0.00%> (+2.50%) ⬆️
datalad/tests/utils.py 51.98% <0.00%> (+20.65%) ⬆️
datalad/tests/test_tests_utils.py 68.55% <0.00%> (+68.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

changelog.d/pr-7082.md Outdated Show resolved Hide resolved
[ci skip]
[appveyor skip]
@yarikoptic
Copy link
Member

hm, I dewarped the changelog snippet and then looked back. benchmarks are failing with something which might actually relate:

fatal: HEAD^1: not a valid SHA1
ram [7110660]: 
Error: Process completed with exit code 128.

rerunning : https://github.com/datalad/datalad/actions/runs/3236005986

@yarikoptic
Copy link
Member

seems to be consistently failing, @jwodder please check what could be the difference between two versions of checkout which would affect it

@jwodder
Copy link
Member Author

jwodder commented Oct 12, 2022

@yarikoptic The Benchmark workflow was previously using v1 of actions/checkout, which checks out the complete history by default, yet v2 and up only check out a single commit by default. Setting fetch-depth: 0 should fix it.

@yarikoptic
Copy link
Member

@yarikoptic The Benchmark workflow was previously using v1 of actions/checkout, which checks out the complete history by default, yet v2 and up only check out a single commit by default. Setting fetch-depth: 0 should fix it.

oh... then it is something to keep for every installation of any module which uses versioneer, versioningit and alike or version would not be deducable. That lead to tests failure on OSX, and it seems even more "fun" situation on testing extensions which then lead to "reinstallation" of datalad from pypi (instead of already reusing the one from checkout) while installing extension: from https://github.com/datalad/datalad/actions/runs/3237400351/jobs/5304414220

2022-10-12T19:51:20.2161287Z Collecting datalad>=0.17.6
2022-10-12T19:51:20.2447327Z   Downloading datalad-0.17.6-py3-none-any.whl (1.4 MB)

so I added to those and other workflows similar depth setting now and pushed. I added even to workflows where it is not exactly needed (e.g. crippled fs - we do not run tests on version to be ok, or disabled windows) so we do not need to figure it out later.
I guess it is something to keep attention to (well, I have merged most of your PRs by now ;))

@yarikoptic
Copy link
Member

I have checked logs of one of the extensions and datalad reported to be

version: 0.17.6+62.g0d3f8e8ed

so all good now, let's proceed, but now with a better awareness of change in semantic of new version of checkout

@yarikoptic yarikoptic merged commit c1081b8 into datalad:maint Oct 13, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.7

@jwodder jwodder deleted the update-actions branch May 12, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants