Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELPNEEDED: Do not resolve symlinks to realpath #745

Merged
merged 2 commits into from
Sep 1, 2016

Conversation

mih
Copy link
Member

@mih mih commented Aug 31, 2016

I believe this creates more headache than it helps. But it seems like an
assumption that is baked in deep. This is to start figuring out
how deep.

I believe this creates more headache than it helps. But it seems like an
assumption that is baked in deep. This is to start figuring out
how deep.
@mih mih changed the title RF: Do not resolve symlinks to realpath HELPNEEDED: Do not resolve symlinks to realpath Aug 31, 2016
@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Coverage decreased (-0.02%) to 86.587% when pulling 5dbfaba on mih:rf-pathresolution into 64730e6 on datalad:master.

@bpoldrack bpoldrack added the conference agenda item Scheduled to be discussed in a developer meeting label Sep 1, 2016
@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 86.76% (diff: 100%)

Merging #745 into master will increase coverage by 0.15%

@@             master       #745   diff @@
==========================================
  Files           195        198     +3   
  Lines         17640      17887   +247   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          15277      15519   +242   
- Misses         2363       2368     +5   
  Partials          0          0          

Powered by Codecov. Last update 64730e6...467bc3f

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage increased (+0.2%) to 86.761% when pulling 467bc3f on mih:rf-pathresolution into 64730e6 on datalad:master.

@mih
Copy link
Member Author

mih commented Sep 1, 2016

Hmm, it passes -- great!

@mih mih merged commit 8c42f85 into datalad:master Sep 1, 2016
@yarikoptic
Copy link
Member

gy... I was working on it atm, merged into my branch as well... and then saw that I have conflicts with master -- because of this one ;) so this one passed -- great ;)

@mih mih deleted the rf-pathresolution branch June 24, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conference agenda item Scheduled to be discussed in a developer meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants