New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstring about "getting subdatasets" in get #7460
Conversation
The docstring said the property is remote-<name>, while the code in _get_flexible_source_candidates_for_submodule() used remoteurl-name.
The doctrings for get and its helper function _get_flexible_source_candidates_for_submodule() seem to have diverged w.r.t. the default costs for subdataset source candidates. This commit brings them back in line by updating get's docstring. Some changes to cost values happened e.g. in 9138af0 After a cursory look, I am under the impression that the values reported in helper function's docstring match its code, and as long as they aren't modified elsewhere these would be the valid ones for get.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## maint #7460 +/- ##
==========================================
+ Coverage 90.73% 91.34% +0.60%
==========================================
Files 325 325
Lines 43399 43399
Branches 0 5818 +5818
==========================================
+ Hits 39380 39642 +262
+ Misses 4019 3742 -277
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for discovering this!
FTR, I see there were errors in the CI runs on CrippledFS 1 and part of Travis runs 2 (though not Appveyor). Given that the PR is docstring-only, I supose they have to be indicative of something unrelated, but I will not have the resources to debug them, and I consider this small PR complete. Footnotes |
Looks LGTM to me, let's proceed! |
PR released in |
This docstring-only PR:
remote-<name>
→remoteurl-<name>
, matching the code)get
docstring (i.e. manpage for get), so that they are the same as in the helper function docstring (_get_flexible_source_candidates_for_submodule()
.Regarding the latter: The doctrings for
get
and its helper function seem to have diverged w.r.t. the default costs for subdataset source candidates. Some changes to cost values happened e.g. in 9138af0. After a cursory look, I am under the impression that the values reported in helper function's docstring match its code (or at least are closer to truth), and as long as they aren't modified elsewhere these would be the valid ones for get.Fixes #7458