Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dev container #117

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Improve dev container #117

merged 5 commits into from
Dec 12, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Dec 12, 2023 •
edited
Loading

Fixes #114
Fixes partly #119

This PR:

  • simplifies the dev container
  • fixes the permission to use it in VS Code
  • adds a CI step to test it

echarles
echarles approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @fcollonval

@fcollonval fcollonval marked this pull request as draft December 12, 2023 08:13
@fcollonval fcollonval marked this pull request as ready for review December 12, 2023 13:38
@fcollonval
Copy link
Member Author

@echarles this is ready for review

@echarles echarles merged commit 757e23c into datalayer:main Dec 12, 2023
3 of 4 checks passed
@fcollonval fcollonval deleted the maintenance/improve-container branch December 12, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev container is not writable
2 participants
@fcollonval @echarles