Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CRITICAL level for Sentry logging #25

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Use CRITICAL level for Sentry logging #25

merged 1 commit into from
Jul 20, 2018

Conversation

reginafcompton
Copy link
Contributor

@reginafcompton reginafcompton commented Jul 20, 2018

This PR turns down the volume on Sentry logging (from "WARN" to "CRITICAL"), like so:

'sentry': {
            'level': 'CRITICAL',
            'class': 'raven.handlers.logging.SentryHandler',
            'client_cls': OCDClient,
            'dsn': ******,
},

@fgregg - we decided to make this change, since the OCD channel in Semaphor has become overly cluttered with cannot resolve pseudo id warnings, and when the 4:00 pm aggressive scrapes begin, the Sempahor channel may become unusable.

@hancush
Copy link
Member

hancush commented Jul 20, 2018

to be clear, these errors will still show up in the scrape logs, so i will have something to consult, on the off chance a resolution error causes a problem tonight? if yes, happy to approve! we can turn it back up on monday.

@hancush
Copy link
Member

hancush commented Jul 20, 2018

(relatedly, are there other errors that won't be logged at this error level?)

@reginafcompton
Copy link
Contributor Author

@hancush - yes, you should still see all the cannot resolve warnings in the logs (right at the end of each import)! I reverted back to the level we had before June 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants