prevent duplicates ids in the parent lookup and make more consistent …

…with get_children
datamapper · Jul 14, 2008 · 74dc532 · 74dc532
1 parent e5bc973
commit 74dc532
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/dm-core/associations/relationship.rb b/lib/dm-core/associations/relationship.rb
@@ -122,8 +122,7 @@ def get_children(parent, options = {}, finder = :all, *args)
 
       # @api private
       def get_parent(child, parent = nil)
-        bind_values = child_key.get(child)
-        child_value = bind_values.dup
+        child_value = child_key.get(child)
         return nil unless child_value.nitems == child_value.size
 
         with_repository(parent || parent_model) do
@@ -136,7 +135,7 @@ def get_parent(child, parent = nil)
 
           children = child_identity_map.values
 
-          bind_values |= children.map { |c| child_key.get(c) }
+          bind_values = *children.map { |c| child_key.get(c) }.uniq
           query_values = bind_values.reject { |k| parent_identity_map[[k]] }
 
           bind_values = query_values unless query_values.empty?