This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
Fix syck cannot dump DirtyMinded Strings #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2011 20:25
The fix excludes Strings from be extended by the Hooker.
| @@ -64,6 +64,24 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe 'with invetions as a string' do | |||
There was a problem hiding this comment.
nitpicking a little: 'invetions' is a typo of 'inventions'
|
@mbj—sorry for losing track of this, Github doesn't ping me when commits are added to a pull request that I'm participating in, so I didn't notice when you fixed the typos. Merging! |
emmanuel
added a commit
that referenced
this pull request
Jan 11, 2012
…trings Fix syck cannot dump DirtyMinded Strings
|
So I'll to @emmanuel spamming in the future :D |
This was referenced Mar 9, 2015
lanej
pushed a commit
to engineyard/dm-types
that referenced
this pull request
Jun 30, 2015
…y-minded-strings Fix syck cannot dump DirtyMinded Strings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix excludes Strings from be extended by the Hooker.
This affects ruby-1.8.7 and ruby-1.9.2 (when using syck), both master and dm-1.2.0.