-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial update and dependency fix #370
Conversation
different .txt works
though, removed using_gnn, making_gnn and ipu_config_tutorial as they are outdated now
Hey thanks for the changes, I've tested this and I'm afraid pip install lightning gives lightning version of 2.0.4 which is not consistent with the 2.1.0 version that we have made changes with. The toymix config are not running as expcted and gives this error: |
This works ok for me: |
Let's ignore the unittest failing for now, it's the stanford datacenter that is down #365 |
@shenyangHuang before merging, can you undo the deletion of the DGL-based tutorials? It's gonna be taken care in issue #374 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the changes for lightning dependencies.
This PR has a temporary fix for the IPU dependency issue. The installation on the README has been updated however the lightning version remains too old.
All current tutorials are able to run and tested.
Removed older tutorials: