Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial update and dependency fix #370

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Tutorial update and dependency fix #370

merged 5 commits into from
Jun 30, 2023

Conversation

shenyangHuang
Copy link
Collaborator

@shenyangHuang shenyangHuang commented Jun 28, 2023

This PR has a temporary fix for the IPU dependency issue. The installation on the README has been updated however the lightning version remains too old.

All current tutorials are able to run and tested.
Removed older tutorials:

  • making gnn networks (for dgl only)
  • using gnn layers (for dgl only)
  • config ipu tutorial (outdated and current IPU configs are nested inside the same config files now), recommended to add newer IPU based tutorials

though, removed using_gnn, making_gnn and ipu_config_tutorial as they
are outdated now
@shenyangHuang shenyangHuang added bug Something isn't working documentation Improvements or additions to documentation labels Jun 28, 2023
@shenyangHuang shenyangHuang self-assigned this Jun 28, 2023
@shenyangHuang shenyangHuang linked an issue Jun 28, 2023 that may be closed by this pull request
@zhiyil1230
Copy link
Contributor

zhiyil1230 commented Jun 29, 2023

Hey thanks for the changes, I've tested this and I'm afraid pip install lightning gives lightning version of 2.0.4 which is not consistent with the 2.1.0 version that we have made changes with. The toymix config are not running as expcted and gives this error:
poptorch.poptorch_core.Error: In poptorch/source/dispatch_tracer/RegisterAtenOverloads.cpp:100: 'poptorch_cpp_error': There is no active dispatch

@zhiyil1230
Copy link
Contributor

zhiyil1230 commented Jun 29, 2023

This works ok for me:
put lightning @ git+https://github.com/Lightning-AI/lightning@ca30fd7752582201a3966806c92e3acbbaf2a045
in a separate file named lightning.txt and run pip install with that separately. @shenyangHuang

@DomInvivo
Copy link
Collaborator

Let's ignore the unittest failing for now, it's the stanford datacenter that is down #365

@DomInvivo
Copy link
Collaborator

@shenyangHuang before merging, can you undo the deletion of the DGL-based tutorials? It's gonna be taken care in issue #374

@shenyangHuang
Copy link
Collaborator Author

Copy link
Contributor

@zhiyil1230 zhiyil1230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the changes for lightning dependencies.

@DomInvivo DomInvivo merged commit 095147a into main Jun 30, 2023
1 of 2 checks passed
@DomInvivo DomInvivo deleted the dependency branch July 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installing lightning dependency not working correctly
3 participants