Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify settings #131

Merged
merged 1 commit into from Nov 28, 2021
Merged

Simplify settings #131

merged 1 commit into from Nov 28, 2021

Conversation

evgeniy-r
Copy link
Member

@evgeniy-r evgeniy-r commented Nov 10, 2021

✓ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list)).

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #131 (c050732) into main (248c8da) will increase coverage by 9.20%.
The diff coverage is 89.74%.

❗ Current head c050732 differs from pull request most recent head 19643f7. Consider uploading reports for the commit 19643f7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   79.43%   88.63%   +9.20%     
==========================================
  Files          52       52              
  Lines        3199     3193       -6     
==========================================
+ Hits         2541     2830     +289     
+ Misses        658      363     -295     
Impacted Files Coverage Δ
cli/pg_datanymizer/src/app.rs 50.00% <0.00%> (ø)
datanymizer_dumper/src/postgres/connector.rs 96.42% <100.00%> (+19.07%) ⬆️
datanymizer_dumper/src/postgres/dumper.rs 88.08% <100.00%> (+54.74%) ⬆️
datanymizer_dumper/src/postgres/row.rs 91.48% <100.00%> (ø)
...atanymizer_dumper/src/postgres/schema_inspector.rs 89.85% <100.00%> (+89.85%) ⬆️
datanymizer_dumper/src/postgres/writer.rs 50.00% <100.00%> (+50.00%) ⬆️
datanymizer_engine/src/engine.rs 96.26% <100.00%> (ø)
datanymizer_engine/src/settings/mod.rs 98.09% <100.00%> (+17.58%) ⬆️
datanymizer_dumper/src/postgres/table.rs 95.36% <0.00%> (+8.27%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69d470...19643f7. Read the comment docs.

@evgeniy-r evgeniy-r self-assigned this Nov 21, 2021
@evgeniy-r evgeniy-r marked this pull request as ready for review November 21, 2021 08:30
Base automatically changed from integration_tests to main November 28, 2021 16:03
@evgeniy-r evgeniy-r merged commit 81dd504 into main Nov 28, 2021
@evgeniy-r evgeniy-r deleted the simplify_settings branch November 28, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants